Skip to content

Enable Node proxy support for GitHub App token steps - #65349

Open
Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:node-use-env-proxy
Open

Jake Bailey (jakebailey) wants to merge 2 commits into
microsoft:mainfrom
jakebailey:node-use-env-proxy

Conversation

@jakebailey

Copy link
Copy Markdown
Member

The jobs are getting newer versions of Node that need NODE_USE_ENV_PROXY=1. I guess I should have listened to the copilot review that mentioned it.

Release jobs run under 1ES network isolation, which sets HTTPS_PROXY.
The token tool uses Node's fetch, which ignores proxy variables unless
NODE_USE_ENV_PROXY=1 is set, so the tool refuses to run and the
GitHub Release step is skipped.
Copilot AI balanced review requested due to automatic review settings November 6, 2026 00:46
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Nov 6, 2026
@typescript-automation typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Nov 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the environment-proxy updates to GitHub App token creation and revocation.

No open issues 🎉

What changed in this PR

Enables Node.js environment-proxy support for GitHub App token operations in Azure Pipelines.

Changes:

  • Sets NODE_USE_ENV_PROXY: "1" for both token creation and revocation steps.
File Description
tools/​pipelines/​steps/​create-github-app-token.yml Enables environment-proxy handling for both Node.js token steps.

Review effort: Balanced

@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Nov 6, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Needs merge

Development

Successfully merging this pull request may close these issues.

3 participants