Repository navigation
Enable Node proxy support for GitHub App token steps - #65349
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Jake Bailey (jakebailey) wants to merge 2 commits into
Conversation
Release jobs run under 1ES network isolation, which sets HTTPS_PROXY. The token tool uses Node's fetch, which ignores proxy variables unless NODE_USE_ENV_PROXY=1 is set, so the tool refuses to run and the GitHub Release step is skipped.
Jake Bailey (jakebailey)
enabled auto-merge
November 6, 2026 00:47
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the environment-proxy updates to GitHub App token creation and revocation.
No open issues 🎉
What changed in this PR
Enables Node.js environment-proxy support for GitHub App token operations in Azure Pipelines.
Changes:
- Sets
NODE_USE_ENV_PROXY: "1"for both token creation and revocation steps.
| File | Description |
|---|---|
tools/pipelines/steps/create-github-app-token.yml |
Enables environment-proxy handling for both Node.js token steps. |
Review effort: Balanced
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jobs are getting newer versions of Node that need
NODE_USE_ENV_PROXY=1. I guess I should have listened to the copilot review that mentioned it.